Relation ManyToOne and qx::dao::insert_with_all_relation

[Davita]

Hi
Is there any way we can pull change requests to a central repository? or how should we contribute to this wonderful project?
I just debugged and fixed this bug viewtopic.php?f=2&t=102 <--. The problem was that, when persisting an object with manyToOne relationship, the object is saved before it's relationship, which caused id mismatch.
here's the fixed QxSqlRelation_ManyToOne.h file: http://dl.dropbox.com/u/3055964/QxSqlRe ... anyToOne.h
I run qxBlog test and several of my test cases and looks like it's working.
This is a fix for QxOrm 1.2.2. I will download latest version and fix that too.

Thanks

[QxOrm admin]

Hi,

Thanx for your patch, I will execute some tests and include it for the next version of QxOrm library (1.2.4)...

Is there any way we can pull change requests to a central repository? or how should we contribute to this wonderful project?

You can create a new thread on this forum or you can send me a mail at : contact@qxorm.com.

About your patch : does it work well when your m_District property is set to NULL before inserting with all relations a City ?

[Davita]

Hmm, you are right, I didn't test with nulls. It definitely has issues and not only the version I sent you.
Looks like it's not possible to save an entity with all_relation, not with my patch, not with unpatched
This looks like another bug. I will try to solve it

Thanks for the hint

[Davita]

Sorry, just to make it clear. It is possible to save an entity with all_relation, it is not possible to save that entity's relation as NULL in database with all_relation.
In this case, if I initialize to NULL m_District's smart pointer, QxOrm will create a row for it, no matter it is null or not.

[QxOrm admin]

Here is a first BETA version of QxOrm 1.2.4 :
http://www.qxorm.com/version/QxOrm_1.2.4_BETA_02.zip

You can download it : this version includes your patch and should have the good behaviour even if your m_District property is set to NULL before calling qx::dao::insert_with_all_relation() function.
Please let me know if all works fine for you with this BETA

[Davita]

Very nice you came up with a solution in this short time. I tried to find out the problem yesterday, but my try didn't yield any results, probably due to the lack of skills in C++
Thank you very much, I will try soon and let you know the result

[QxOrm admin]

Ok, I will wait for your results.
I created a new forum called "Submit a patch" : I will move this discussion into the new forum...

[Davita]

I just tested it and it works flawlessly
Thank you for your commitment. I will continue development on my project, and in case I find anything, I'll try to fix it, otherwise I'll notify about the issue