Patch to QxOrm.pri

You find a bug using QxOrm library and you know how to fix it : submit a patch on this forum

Patch to QxOrm.pri

Postby mdw » Wed Feb 17, 2016 9:58 am

Include support for all MSVC compilers:

#############################
# Compiler / Linker Options #
#############################

win32 {
CONFIG(debug, debug|release) {
} else {
DEFINES += NDEBUG
win32-msvc*: QMAKE_LFLAGS += /OPT:NOREF
} # CONFIG(debug, debug|release)
win32-g++: QMAKE_LFLAGS += -Wl,-export-all-symbols -Wl,-enable-auto-import
} # win32
mdw
 
Posts: 34
Joined: Mon Feb 15, 2016 2:45 pm

Re: Patch to QxOrm.pri

Postby qxorm » Wed Feb 17, 2016 4:54 pm

Hello,

Thank you for the patch : I will test it (especially with older versions of qmake).
If everything works fine, I will add it to the next version of QxOrm library.
qxorm
Site Admin
 
Posts: 483
Joined: Mon Apr 12, 2010 7:45 am

Re: Patch to QxOrm.pri

Postby qxorm » Fri Feb 19, 2016 2:08 pm

I tested a bit the /OPT:NOREF linker parameter :
- it is necessary for older compiler (like MSVC 2008) ;
- it is not necessary and increases output binary size for nothing with newer compiler (like MSVC 2012, so I suppose this is also true for MSVC 2013 and MSVC 2015).

So I will not apply your patch, this part of QxOrm.pri will remain :
Code: Select all
win32 {
CONFIG(debug, debug|release) {
} else {
DEFINES += NDEBUG
win32-msvc2005: QMAKE_LFLAGS += /OPT:NOREF
win32-msvc2008: QMAKE_LFLAGS += /OPT:NOREF
win32-msvc2010: QMAKE_LFLAGS += /OPT:NOREF
} # CONFIG(debug, debug|release)
win32-g++: QMAKE_LFLAGS += -Wl,-export-all-symbols -Wl,-enable-auto-import
} # win32
qxorm
Site Admin
 
Posts: 483
Joined: Mon Apr 12, 2010 7:45 am

Re: Patch to QxOrm.pri

Postby mdw » Mon Feb 22, 2016 8:10 am

Ah okay, so this was intentional.
mdw
 
Posts: 34
Joined: Mon Feb 15, 2016 2:45 pm


Return to QxOrm - Submit a patch

Who is online

Users browsing this forum: No registered users and 1 guest